Shuttle Enters Hangar with Open Wings

Any issues with the XWAU or X-Wing Alliance? Please let us know here!

Re: Shuttle Enters Hangar with Open Wings

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Mon Jun 13, 2022 1:34 am

Leofus wrote: ↑
Mon Jun 06, 2022 7:23 pm
B6M5 the shuttle tyderium closes its wings when entering the liberty.
it would be cool if the shuttles and landing craft had their sfoils closed while in the 'hold steady' and 'wait' orders so they arent all sitting in the hangar with their wings open. i set the landing craft and shuttles to 'ParkOrderSFoilsClosed = 1' and tried to edit the mission to switch them all to 'park' and their s-foils are closed but for some reason they all keep moving from their places even if i set the throttle to 0. i even tried setting every order and waypoint to the same spot with throttle 0 but they still move for some reason
I know see what you were referring to with this mission.
I am going to see what options can be used for the S-foils in the hangar.
Might need to recreate some stuff as it takes forever to get there and test.
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
JeremyaFr
XWAU Member
Posts: 3921
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Wed Jun 15, 2022 5:22 pm

WIP

Hello,
Here is a WIP of the hangars hook.

I've fixed a bug where the FoldOutside setting is read from the wrong file.

EDIT: link removed
Last edited by JeremyaFr on Thu Jun 16, 2022 3:51 pm, edited 1 time in total.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Wed Jun 15, 2022 7:10 pm

@Leofus if you could test that please, it would be appreciated.
Make sure it's on a mission that has its defaults applied, non modded.
Same with the opt. So revert back to how it was released.
Thanks a lot πŸ˜ŽπŸ‘
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Wed Jun 15, 2022 8:09 pm

Ace Antilles wrote: ↑
Wed Jun 15, 2022 7:10 pm
@Leofus if you could test that please, it would be appreciated.
Make sure it's on a mission that has its defaults applied, non modded.
Same with the opt. So revert back to how it was released.
Thanks a lot πŸ˜ŽπŸ‘
seriously thank you so much Ace and Jeremy! i feel like a kid on christmas. im gonna go 'unwrap' this and try it out and i will report right back!
Last edited by Leofus on Wed Jun 15, 2022 9:39 pm, edited 1 time in total.

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Wed Jun 15, 2022 9:08 pm

unfortunately this didn't resolve the issue.
i tried b3m6 and b3m7. aa-23 entered the redemption and the imperator with open sfoils.
i tried removing the ;blabla from after foldoutside in frigate2medical.ini and that didnt help either.
i am very grateful that someone is trying to resolve this though. thanks for the efforts!

edit: the install i am using is all official. the only thing changed from the xwau files is the frigate2medical.ini

edit2: i am honestly curious why foldoutside is even a setting. i cannot imagine a scenario where you would want craft to enter another craft with open sfoils. maybe i just lack imagination
Last edited by Leofus on Wed Jun 15, 2022 10:01 pm, edited 2 times in total.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Wed Jun 15, 2022 10:41 pm

Leofus wrote: ↑
Wed Jun 15, 2022 9:08 pm
unfortunately this didn't resolve the issue.
i tried b3m6 and b3m7. aa-23 entered the redemption and the imperator with open sfoils.
i tried removing the ;blabla from after foldoutside in frigate2medical.ini and that didnt help either.
i am very grateful that someone is trying to resolve this though. thanks for the efforts!

edit: the install i am using is all official. the only thing changed from the xwau files is the frigate2medical.ini

edit2: i am honestly curious why foldoutside is even a setting. i cannot imagine a scenario where you would want craft to enter another craft with open sfoils. maybe i just lack imagination
It's because without the foldoutside option the wings weren't folding at all before that.

Thank you for your test. I'm sure Jeremy will keep looking into it as he can.
Bug fixing options for this ancient game can be very tricky.
Plus time is limited with other innovations and more important areas being looked into.
So hopefully it can be sorted but we can't give any eta of when that maybe.
(Normally now Jeremy pops up with a miracle cure after I have said that) :D
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Wed Jun 15, 2022 10:49 pm

Ace Antilles wrote: ↑
Wed Jun 15, 2022 10:41 pm
It's because without the foldoutside option the wings weren't folding at all before that.
at what point did that happen? i mean in the original completely unmodded game the shuttle folded its wings when entering the hangar in these particular missions.

edit: i checked b6m5 and the shuttle still closes its wings when entering the liberty

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Thu Jun 16, 2022 12:56 am

Leofus wrote: ↑
Wed Jun 15, 2022 10:49 pm
Ace Antilles wrote: ↑
Wed Jun 15, 2022 10:41 pm
It's because without the foldoutside option the wings weren't folding at all before that.
at what point did that happen? i mean in the original completely unmodded game the shuttle folded its wings when entering the hangar in these particular missions.

edit: i checked b6m5 and the shuttle still closes its wings when entering the liberty
Ok so I tested the new Hook with a test mission.
Shuttle OPAL arrives 15 seconds after the player and it is set to "Fly Home" to the CRL.
Shuttle OPAL closes it's S-foils when it reaches the CRL Valiants "OutsideHangar" HP as intended.
Then it enters the hangar.

flightscreen0.jpg
flightscreen2.jpg

So for me this is working properly @JeremyaFr .
Now if it's not working right on other missions then that could be the mission.

@Leofus I have included the test mission.
Copy 1B1M1G as a backup and replace with this and delete TEST from the name.
You do not have the required permissions to view the files attached to this post.
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Thu Jun 16, 2022 1:12 am

Ace Antilles wrote: ↑
Thu Jun 16, 2022 12:56 am
Leofus wrote: ↑
Wed Jun 15, 2022 10:49 pm
Ace Antilles wrote: ↑
Wed Jun 15, 2022 10:41 pm
It's because without the foldoutside option the wings weren't folding at all before that.
at what point did that happen? i mean in the original completely unmodded game the shuttle folded its wings when entering the hangar in these particular missions.

edit: i checked b6m5 and the shuttle still closes its wings when entering the liberty
Ok so I tested the new Hook with a test mission.
Shuttle OPAL arrives 15 seconds after the player and it is set to "Fly Home" to the CRL.
Shuttle OPAL closes it's S-foils when it reaches the CRL Valiants "OutsideHangar" HP as intended.
Then it enters the hangar.


flightscreen0.jpgflightscreen2.jpg


So for me this is working properly @JeremyaFr .
Now if it's not working right on other missions then that could be the mission.

@Leofus I have included the test mission.
Copy 1B1M1G as a backup and replace with this and delete TEST from the name.
ok i will do this but i have noted several times that the shuttle closes its wings in some instances and in other instances it does not. in fact you just quoted me saying the shuttle closes its wings when entering the liberty. so far since the hook has been updated i have said b3m6 and b3m7 shuttles do not close their sfoils and b6m5 they do close their sfoils just as before this hook update. so it is worth noting that nothing changed. it still doesnt work in the instances it didnt work before and it still works in the instances it worked before the hook update.

edit: i have run your test mission and witnessed the shuttle opal closing sfoils when entering cruiser valiant. if you run b3m6 and b3m7 will you see aa-23 enter the redemption and the imperator with open sfoils?
Last edited by Leofus on Thu Jun 16, 2022 1:55 am, edited 2 times in total.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Thu Jun 16, 2022 1:53 am

Sorry if I misunderstood you :( It's 2.45am and I'm working on other priority XWAU stuff with a deadline.
What we can gather from this test though is the Hook is working as intended. That stops lots of other attempts to fix what may not be broken.

So b3m6 and b3m7 are not working.

This could be that because there are other orders active before the Fly Home order is enabled.
This is part of the problem we have had with Parking and Sfoils.

You could edit the mission and change the goals so it just flys home and see what happens. Even though the mission may not be completed.

It will have to go on the list to be looked into at a later date.
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Thu Jun 16, 2022 1:55 am

Ace Antilles wrote: ↑
Thu Jun 16, 2022 1:53 am
Sorry if I misunderstood you :( It's 2.45am and I'm working on other priority XWAU stuff with a deadline.
What we can gather from this test though is the Hook is working as intended. That stops lots of other attempts to fix what may not be broken.

So b3m6 and b3m7 are not working.

This could be that because there are other orders active before the Fly Home order is enabled.
This is part of the problem we have had with Parking and Sfoils.

You could edit the mission and change the goals so it just flys home and see what happens. Even though the mission may not be completed.

It will have to go on the list to be looked into at a later date.
after running that test mission i restored and ran the original b1m1 and im sure you know that in the original mission shu opal enters the valiant at the end of the mission rather than the beginning and the funniest thing... running the original b1m1 with the new hangar hook shu opal enters the cruiser valiant with open sfoils and xwings enter defiance with open sfoils as well. i know i am no expert but just because the hook works as intended in one instance does not justify eliminating it as an influence in other instances. the only conclusions we can draw from this testing are:

1. the sfoils work less often than they do when entering hangars
2. whatever changed in the hangar hook had no discernible effect on this issue

i know there are many variables but without the hooks and the new opts the shuttles folded their wings when entering hangars in these particular missions so the fact of the matter is something in the mod is causing a function in the original game to stop functioning and as much as i appreciate the test mission, the original version of that mission doesn't function with the new hook so if you will use that one to test it, you must say that it does not work.

User avatar
JeremyaFr
XWAU Member
Posts: 3921
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Thu Jun 16, 2022 3:53 pm

WIP

Hello,
Here is a new WIP of the hangars hook.

I've removed the FoldOutside setting. Now the feature is enabled for all crafts.

Note that for now it only applies to the AI Fly Home order.

EDIT: link removed
Last edited by JeremyaFr on Sat Jun 18, 2022 4:11 pm, edited 1 time in total.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Thu Jun 16, 2022 4:52 pm

JeremyaFr wrote: ↑
Thu Jun 16, 2022 3:53 pm
WIP

Hello,
Here is a new WIP of the hangars hook.

I've removed the FoldOutside setting. Now the feature is enabled for all crafts.

Note that for now it only applies to the AI Fly Home order.

xwa_hook_hangars_WIP_2206161750.zip
Does this mean there's no point having the foldoutside setting included in the ini files anymore?

Is that correct?
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

User avatar
JeremyaFr
XWAU Member
Posts: 3921
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Thu Jun 16, 2022 5:26 pm

Ace Antilles wrote: ↑
Thu Jun 16, 2022 4:52 pm
Does this mean there's no point having the foldoutside setting included in the ini files anymore?
Is that correct?
Yes
But it is still a WIP.

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Thu Jun 16, 2022 7:11 pm

JeremyaFr wrote: ↑
Thu Jun 16, 2022 3:53 pm
WIP

Hello,
Here is a new WIP of the hangars hook.

I've removed the FoldOutside setting. Now the feature is enabled for all crafts.

Note that for now it only applies to the AI Fly Home order.


xwa_hook_hangars_WIP_2206161750.zip
thank you very much! your work is appreciated. i will test as soon as possible and report.

edit: i first tested with b1m1 and opal entered valiant with open sfoils as before. i will go back and retest the other missions as well.

congratulations on 6666 posts ace. i just want to say thanks again for all you guys do. seriously. that goes for ace, jeremy and everyone else who have contributed

edit: im going to make a little more effort and compile all of my testing into a concise, coherent log format

User avatar
JeremyaFr
XWAU Member
Posts: 3921
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Sat Jun 18, 2022 4:12 pm

Hello,
I've uploaded a new version of the hangars hook.

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Sat Jun 18, 2022 7:03 pm

JeremyaFr wrote: ↑
Sat Jun 18, 2022 4:12 pm
Hello,
I've uploaded a new version of the hangars hook.
thanks jeremya. youre the man! i tried using XwaHooksSetup but the version it downloaded says last modified in january (259kb)

User avatar
JeremyaFr
XWAU Member
Posts: 3921
Joined: Mon Jan 18, 2010 5:52 pm
Contact:

Post by JeremyaFr » Sat Jun 18, 2022 7:12 pm

Leofus wrote: ↑
Sat Jun 18, 2022 7:03 pm
thanks jeremya. youre the man! i tried using XwaHooksSetup but the version it downloaded says last modified in january (259kb)
Please redownload XwaHooksSetup and retry
Or use this direct link:
https://github.com/JeremyAnsel/xwa_hook ... angars.dll

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Sat Jun 18, 2022 7:36 pm

JeremyaFr wrote: ↑
Sat Jun 18, 2022 7:12 pm
Leofus wrote: ↑
Sat Jun 18, 2022 7:03 pm
thanks jeremya. youre the man! i tried using XwaHooksSetup but the version it downloaded says last modified in january (259kb)
Please redownload XwaHooksSetup and retry
Or use this direct link:
https://github.com/JeremyAnsel/xwa_hook ... angars.dll
got it now. cant wait to try. thanks again!

edit: so far with the newest hook i have tested the following missions:
b1m1 shuttle opal enters cruiser valiant with open sfoils, xwing red enters defiance with open sfoils
b3m6 shuttle aa23 enters frigate redemption with open sfoils
b3m7 shuttle aa23 enters destroyer imperator with open sfoils
b4m5 shuttle felyas pride enters cruiser liberty with open sfoils
b5m5 shuttle merte closes sfoils upon entering the cruiser liberty
b6m1 shuttle jade enters liberty with open sfoils, shuttle jade enters dreadnaught talcara with open sfoils, shuttle compassion enters liberty with open sfoils
b6m5 shuttle tyderium closes sfoils upon entering liberty, xwing rogue closes sfoils upon entering liberty
Last edited by Leofus on Sun Jun 19, 2022 12:37 pm, edited 4 times in total.

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Sun Jun 19, 2022 1:52 am

Leofus wrote: ↑
Sat Jun 18, 2022 7:36 pm
edit: so far with the newest hook i have tested the following missions:
b1m1 shuttle opal enters cruiser valiant with open sfoils, xwing red enters defiance with open sfoils
b3m6 shuttle aa23 enters frigate redemption with open sfoils
b3m7 shuttle aa23 enters destroyer imperator with open sfoils
b4m5 shuttle felyas pride enters cruiser liberty with open sfoils
This hook had no alterations to this bug. It's to do with orders I'm sure. But no progress can be made to check at this time.

1B6M5B - There are clearly some issues with the Park command. It can do some bizarre things. Sometimes it works and sometimes not.
So for now we can't enable Park with S-folis closed by default on Shuttles as they won't open them again.

I have included a test mission and also an INI to use.
This is the best I can do for now. It will close the S-foils on the Landing Craft.
Feel free to give it a test
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Sun Jun 19, 2022 5:54 am

Ace Antilles wrote: ↑
Sun Jun 19, 2022 1:52 am
Leofus wrote: ↑
Sat Jun 18, 2022 7:36 pm
edit: so far with the newest hook i have tested the following missions:
b1m1 shuttle opal enters cruiser valiant with open sfoils, xwing red enters defiance with open sfoils
b3m6 shuttle aa23 enters frigate redemption with open sfoils
b3m7 shuttle aa23 enters destroyer imperator with open sfoils
b4m5 shuttle felyas pride enters cruiser liberty with open sfoils
This hook had no alterations to this bug. It's to do with orders I'm sure. But no progress can be made to check at this time.

1B6M5B - There are clearly some issues with the Park command. It can do some bizarre things. Sometimes it works and sometimes not.
So for now we can't enable Park with S-folis closed by default on Shuttles as they won't open them again.

I have included a test mission and also an INI to use.
This is the best I can do for now. It will close the S-foils on the Landing Craft.
Feel free to give it a test
i know i know. you already said it is "working as intended" which is true i guess if you intend for it to work 10% of the time

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Sun Jun 19, 2022 10:37 am

No it's not working as intended.
It works fine if Fly Home is set.
I'm saying it's the other orders that are an issue. It worked for me with a Park command once which is why it's not auto enabled.

Which is why I spent my short free time making changes to that mission to improve it for people to enjoy.

We appreciate your help with this issue but you must have patience. Thank you
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Sun Jun 19, 2022 10:50 am

Ace Antilles wrote: ↑
Sun Jun 19, 2022 10:37 am
No it's not working as intended.
It works fine if Fly Home is set.
I'm saying it's the other orders that are an issue. It worked for me with a Park command once which is why it's not auto enabled.

Which is why I spent my short free time making changes to that mission to improve it for people to enjoy.

We appreciate your help with this issue but you must have patience. Thank you
shuttle opal's order is fly home. shuttle aa-23's order is fly home in both missions with issues. shuttle felyas pride's order is fly home. not sure what you mean. i appreciate you getting the landing craft to sit with closed sfoils but you dont need to keep reminding me that nobody is working on this issue or that the hook updates are not pertaining to this.
Last edited by Leofus on Sun Jun 19, 2022 1:40 pm, edited 1 time in total.

Leofus
Cadet 1st Class
Posts: 143
Joined: Wed Jan 11, 2006 12:01 am

Post by Leofus » Sun Jun 19, 2022 1:40 pm

Ace Antilles wrote: ↑
Sun Jun 19, 2022 1:52 am
Leofus wrote: ↑
Sat Jun 18, 2022 7:36 pm
edit: so far with the newest hook i have tested the following missions:
b1m1 shuttle opal enters cruiser valiant with open sfoils, xwing red enters defiance with open sfoils
b3m6 shuttle aa23 enters frigate redemption with open sfoils
b3m7 shuttle aa23 enters destroyer imperator with open sfoils
b4m5 shuttle felyas pride enters cruiser liberty with open sfoils
This hook had no alterations to this bug. It's to do with orders I'm sure. But no progress can be made to check at this time.

1B6M5B - There are clearly some issues with the Park command. It can do some bizarre things. Sometimes it works and sometimes not.
So for now we can't enable Park with S-folis closed by default on Shuttles as they won't open them again.

I have included a test mission and also an INI to use.
This is the best I can do for now. It will close the S-foils on the Landing Craft.
Feel free to give it a test
i peeked in that ini and expanded the sfoils instructions to all craft in the hangar except the ones that take off. it works great! i really appreciate it. thank you, ace

User avatar
Ace Antilles
Admiral (Moderator)
Posts: 7829
Joined: Sat Jan 22, 2000 12:01 am
Contact:

Post by Ace Antilles » Sun Jun 19, 2022 2:20 pm

Leofus wrote: ↑
Sun Jun 19, 2022 1:40 pm
i peeked in that ini and expanded the sfoils instructions to all craft in the hangar except the ones that take off. it works great! i really appreciate it. thank you, ace
I thought I had already done that?
Don't all the Lambda Shuttles take off or am I wrong?
Which ones did you add please.
Plus doesn't that kinda give away which one is which :lachtot:
Chief XWAU Team annoying nitpicker.
Ace Antilles - The X-Wing Outpost
Image

Post Reply